fix(BuildTicketCreationDataAction): deduplicate emulators #3236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3234.
Root Cause
I have never been able to repro this issue locally, but I can see how it would happen. Because emulator names are not normalized in
addInactiveEmulators
, subtle nuances in the decoded client string could plausibly cause a duplicate emulator to be inserted into the$emulators
collection.We could alternatively solve this issue in the front-end, but that feels too far downstream when it's technically a logic error in the back-end action.