Mapping Solution #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wscheffer
reviewed
Jul 21, 2023
| import java.util.stream.Collectors; | ||
|
|
||
| @Mapper(componentModel = "spring") | ||
| public abstract class IArticleMapper { |
There was a problem hiding this comment.
Why does the name of the Abstract class start with an I.
I is traditionally used for Interface and Java devs normally prefix abstract classes with Abstract, thin it comes from the days before Intellisense
wscheffer
reviewed
Jul 21, 2023
|
|
||
| @Override | ||
| public ArticleBlockDto map(ArticleBlock entity) { | ||
| return null; |
wscheffer
reviewed
Jul 21, 2023
|
|
||
| @Override | ||
| public ArticleBlock map(ArticleBlockDto entity) { | ||
| return null; |
There was a problem hiding this comment.
Why is there no toBlock for this method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.