Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBI Mengubah Status Venue #12

Merged
merged 4 commits into from
Feb 25, 2024
Merged

PBI Mengubah Status Venue #12

merged 4 commits into from
Feb 25, 2024

Conversation

catherineeangel
Copy link
Contributor

@catherineeangel catherineeangel commented Feb 25, 2024 •
edited
Loading

  1. Update model venue for field status
  • change field to enum with value : None, Pending, Waitlist, Confirmed, Cancelled
  1. Add Update Status View
  • url: /venues/:id/status
  • method: PATCH
  • body: {
    status : string
    }

@catherineeangel catherineeangel changed the base branch from main to staging February 25, 2024 15:36
@catherineeangel catherineeangel requested review from emiriko and nataniadeandra and removed request for emiriko February 25, 2024 15:36
nataniadeandra
nataniadeandra approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@nataniadeandra nataniadeandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good😃

JohannesSetiawan
JohannesSetiawan approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@JohannesSetiawan JohannesSetiawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and the test has good coverage the possible cases that can happen.

@catherineeangel catherineeangel merged commit b9a307e into staging Feb 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesSetiawan JohannesSetiawan JohannesSetiawan approved these changes

@nataniadeandra nataniadeandra nataniadeandra approved these changes

@emiriko emiriko Awaiting requested review from emiriko

@swastikanata swastikanata Awaiting requested review from swastikanata

@carlenee carlenee Awaiting requested review from carlenee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@catherineeangel @JohannesSetiawan @nataniadeandra