feat: PBI-Profil

[carlenee]

Detailed description of changes
What's New
N / A

What's Updated
Added Update Profile Feature and Tests

New Package Added
N/A

Recommendations on how to test the changes
N / A

Checklist for developer

• The code builds clean without any errors or warnings
• The code does not contain commented out code
• The code does not log anything to console
• I have added unit test(s) to cover new code and successfully executed ran it
• I have thoroughly tested the new code and any adjacent features it may affect

Link to related issue(s)
N / A

Screenshots or videos (before and after if appropriate)
Before
N / A

After
N / A

[JohannesSetiawan]

Overall, the code are good. The models, views, and serializers are good. But i guess you didn't merge the staging branch to your branch before you made this request so some of my code were missing in tests.py. Please do that first.

[emiriko]

Also try to git ignore the profile_pictures directory, because we don't need to save it on github (will use too much resource)

[emiriko]

My suggestion is to not use /update here. You can utilize ProfileView instead (change UpdateProfileView to ProfileView) to utilize the APIView from drf.

[emiriko]

Change the file to be ProfileView(APIView). Because u might want to get user profile so if that's the case, you will want to add get method on the class.

For example:

class ProfileView(APIView):
    def get(self, request):
        # Implement the get logic here.
        
    def put(self, request):
        user = request.user
        profile = user.profile
        serializer = ProfileSerializer(instance=profile, data=request.data, partial=True)
        if serializer.is_valid():
            serializer.save()
            return Response({'msg': 'Profile updated successfully!'})
        else:
            return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)

This will make your code more efficient. Overall great implementation, keep it up!

[emiriko]

Great job!

[swastikanata]

Looks good to me, very detail description too!