Feat: implement payment #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catherineeangel
requested review from
swastikanata,
JohannesSetiawan,
carlenee,
emiriko and
nataniadeandra
emiriko
requested changes
May 12, 2024
src/app/package/page.tsx
Outdated
| const features: (keyof PackageDetailResponse)[] = [ | ||
| 'event_planner', | ||
| 'event_tracker', | ||
| 'event_timeline', | ||
| 'event_rundown', | ||
| 'ai_assistant', | ||
| ] | ||
| useEffect(() => { | ||
| if (!!data) { |
There was a problem hiding this comment.
Based on analysis on sonarcloud, this type of redundant double negation will cause code smell on our codes. I get that you want to cast it to boolean, but perhaps to minimize the amount of code smells, it's better to not use double negation.
The reason for this could be seen here:
https://sonarcloud.io/organizations/reveliostartup/rules?open=typescript%3AS6509&rule_key=typescript%3AS6509
There was a problem hiding this comment.
okay, thanks for the info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have implemented the integration of payment and transaction api.
This allows user to buy our premium package.
I also have done some refactoring for some of the elements's styling and remove unused component.