PBI Transaction History #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catherineeangel
requested review from
swastikanata,
JohannesSetiawan,
carlenee,
emiriko and
nataniadeandra
JohannesSetiawan
requested changes
May 16, 2024
emiriko
requested changes
May 16, 2024
| {formatRupiah(price)} | ||
| </td> | ||
| <td className="p-2 border-2 border-emerald-500"> | ||
| {dayjs(expiry_time).format('ddd, D MMM YY HH:mm')} |
There was a problem hiding this comment.
I think there are plenty of time in our projects that we use dayjs and format it to a certain format. I think it's better to make utils function for better code readability.
There was a problem hiding this comment.
ok thanks for suggesting this, I have rafactored the code and make it more modular.
src/app/payment/PaymentDetail.tsx
Outdated
Comment on lines
30
to
31
| if (transactionErrorStatuses.includes(status ?? '')) | ||
| return <PaymentError status={status ?? ''} /> |
There was a problem hiding this comment.
In here, is there really a case where status is null? If there are, I think you could define status as a type of possible values to reduce confusion
There was a problem hiding this comment.
You're right. Thanks for pointing that outl.
JohannesSetiawan
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have applied the transaction history feature for the app. I have applied this so that user can continue pending transaction that has not expired.