Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOP] beautify interface #83

Merged
merged 3 commits into from
May 26, 2024
Merged

[REFACTOP] beautify interface #83

merged 3 commits into from
May 26, 2024

Conversation

carlenee
Copy link
Contributor

I changed the payment options in the landing page
before:
image
after:
image
to match the components in the /package page

I also changed the loader in the create event page so that it doesnt overlap with the planning button to a loader that we use in every page for consistency

Copy link
Contributor

@JohannesSetiawan JohannesSetiawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@catherineeangel catherineeangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

Copy link
Contributor

@nataniadeandra nataniadeandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! This makes our website much more consistent.

Copy link
Member

@emiriko emiriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Carlene, good job on beautifying our frontend. I have one request, and I think this would make that interface super nice looking.

I think the top right border radius and bottom right radius should be removed right? Because we want to make it feel as if the package are combined. This is what i meant

image

Copy link
Contributor

@swastikanata swastikanata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this code looks good!

@carlenee
Copy link
Contributor Author

Hi Carlene, good job on beautifying our frontend. I have one request, and I think this would make that interface super nice looking.

I think the top right border radius and bottom right radius should be removed right? Because we want to make it feel as if the package are combined. This is what i meant

image

image
done!

@carlenee carlenee requested a review from emiriko May 26, 2024 10:55
Copy link
Member

@emiriko emiriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, Nice! LGTM.

@carlenee carlenee merged commit ca3141d into staging May 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants