Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web sdk customers identity #564

Merged
merged 7 commits into from
Dec 19, 2024
Merged

Conversation

nicfix
Copy link
Contributor

@nicfix nicfix commented Dec 18, 2024

Motivation / Description

Updated the Identifying Customers section to reflect the changes made with the redemption links

Copy link

Preview this PR here: https://dev-docs.revenuecat.com/pr-564/

@vicfergar vicfergar requested review from MrEdwardo and a team December 18, 2024 11:07
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment but LGTM!

## Identifying customers
## Identifying Customers

The RevenueCat Web SDK supports both [identified](/customers/user-ids) and [non-identified (anonymous)](/customers/user-ids#anonymous-app-user-ids) customers, offering flexibility in how you manage user accounts and subscriptions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some code sample on how to initialize the SDK anonymously?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense. Adding them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I guess we should update this section right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2 examples, repeating the one on top for identified customers, and added a new one for the anonymous.

I think it's fine since we have the Identifying Customers right after the Configuring the SDK.
It would be confusing to first give both examples and then explain the differences.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also reverse the order of the sections, starting with Identifying customers followed by SDK configuration with both examples, wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a line to "connect" the 2 sections, let me know if it makes more sense like this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer to avoid snippet duplication and just reverse the order of these two sections. Another benefit is that all SDK sections appear sequentially, but it’s not a blocker either.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrEdwardo we need a tie breaker 🙂

Copy link
Contributor

@MrEdwardo MrEdwardo Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicfix I think I'm okay with the snippet duplication in this case, to clearly separate the different cases

@nicfix nicfix requested a review from a team December 18, 2024 12:00
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about the indentation. After that and Victor's comments, :shipit:

@nicfix nicfix merged commit 65773bb into anonymous-purchases Dec 19, 2024
3 checks passed
@nicfix nicfix deleted the web-sdk-customers-identity branch December 19, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants