Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flutter deprecated logging #650

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Update flutter deprecated logging #650

merged 1 commit into from
Feb 17, 2025

Conversation

marcucio
Copy link
Contributor

Motivation / Description

code was deprecated, changed it to the correct code

Changes introduced

Linear ticket (if any)

Additional comments

@marcucio marcucio requested a review from a team as a code owner February 14, 2025 21:26
@nihalgonsalves nihalgonsalves requested a review from a team February 17, 2025 11:15
tonidero
tonidero approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing I wonder is why this is in a js file instead of a dart file 😅 but that's unrelated to the changes here. This looks good! Thank you for updating this! 🙏

@nihalgonsalves
Copy link
Member

@tonidero I think it's just a quirk of how these files are imported into MDX as raw source files, probably can be fixed with some config.

@nihalgonsalves nihalgonsalves merged commit 63a4c00 into RevenueCat:main Feb 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonidero tonidero tonidero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcucio @nihalgonsalves @tonidero