Fix @MainActor reference in unsupported OS versions
#4612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
aboedo
commented
Dec 19, 2024
| @@ -33,11 +33,18 @@ public typealias PurchaseResultData = (transaction: StoreTransaction?, | |||
| /** | |||
| Completion block for ``Purchases/purchase(product:completion:)`` | |||
| */ | |||
| #if swift(>=5.5) && canImport(_Concurrency) | |||
There was a problem hiding this comment.
I believe the swift concurrency import check would work
There was a problem hiding this comment.
I think since this is a compiler conditional, canImport only checks if the version of Xcode you're compiling with supports concurrency.
And since @MainActor is supposedly back ported to macOS 10/11, and the current version of Xcode supports concurrency, this means we would end up always compiling the first branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1826 introduced references to
@MainActorthat are utilized in OS versions that don't support Swift Concurrency - namely, iOS 11-12 and macOS 10.12-10.14.This PR addresses it by using a compilation flag.