Evolve lysosomes in auto-evo #5847
Conversation
|
I would argue that this probably should effect the energy gained by predation, but the energy system really isn't setup that way, so that is probably better left to a rework of that system. Might be good to open an issue on it. |
# Conflicts: # locale/af.po # locale/ar.po # locale/be.po # locale/bg.po # locale/bn.po # locale/ca.po # locale/cs.po # locale/da.po # locale/de.po # locale/el.po # locale/en.po # locale/eo.po # locale/es.po # locale/es_AR.po # locale/et.po # locale/fi.po # locale/fr.po # locale/frm.po # locale/he.po # locale/hr.po # locale/hu.po # locale/id.po # locale/it.po # locale/ka.po # locale/ko.po # locale/la.po # locale/lb_LU.po # locale/lt.po # locale/lv.po # locale/messages.pot # locale/mk.po # locale/nb_NO.po # locale/nl.po # locale/nl_BE.po # locale/pl.po # locale/pt_BR.po # locale/pt_PT.po # locale/ro.po # locale/ru.po # locale/si_LK.po # locale/sk.po # locale/sr_Cyrl.po # locale/sr_Latn.po # locale/sv.po # locale/th_TH.po # locale/tok.po # locale/tr.po # locale/tt.po # locale/uk.po # locale/vi.po # locale/zh_CN.po # locale/zh_TW.po
| var predationToolsRawScores = (pilusScore, oxytoxyScore, slimeJetScore, mucocystsScore); | ||
|
|
||
| cachedPredationToolsRawScores.Add(microbeSpecies, predationToolsRawScores); | ||
| return predationToolsRawScores; | ||
| } | ||
|
|
||
| public (float EnzymesScore, bool IsMembranedigestable) GetEnzymesScores(MicrobeSpecies predator, |
There was a problem hiding this comment.
Is there a reason why this doesn't just return 0 when indigestible?
There was a problem hiding this comment.
The engulfment score is muliplied by enzymes score so its default value is 1, if that's what you mean
There was a problem hiding this comment.
No, I meant that as there's only use of the score inside a check with the bool, you might as well just return 0 if the bool would be false. In fact I've done that change and I'll push what I have in a minute or so for you to look at.
There was a problem hiding this comment.
but maybe you're right and I should return only 0 if IsMembranedigestable is false , otherwise return the enzyme score
| { | ||
| if (organelle.Definition.HasLysosomeComponent) | ||
| { | ||
| foreach (var enzyme in organelle.Definition.Enzymes.Where(enzyme => enzyme.Value > 0)) |
There was a problem hiding this comment.
This LINQ usage should be avoided as this allocates a bunch of temporary memory. I'm doing some style changes already for this PR, so I can change this as well. I'll just comment for letting you know to watch out for this in the future.
There was a problem hiding this comment.
Also I think I found a major problem here, using Name instead of InternalName means that the scores were never read from the score dictionary. I'll push what I have but I think I'll need your help to rebalance all the numbers to work.
and switch to a string builder as a lot of text is appended
handling to actually account how engulfing is not totally useless without any enzymes
# Conflicts: # locale/af.po # locale/ar.po # locale/be.po # locale/bg.po # locale/bn.po # locale/ca.po # locale/cs.po # locale/da.po # locale/de.po # locale/el.po # locale/en.po # locale/eo.po # locale/es.po # locale/es_AR.po # locale/et.po # locale/fi.po # locale/fr.po # locale/frm.po # locale/he.po # locale/hr.po # locale/hu.po # locale/id.po # locale/it.po # locale/ka.po # locale/ko.po # locale/la.po # locale/lb_LU.po # locale/lt.po # locale/lv.po # locale/messages.pot # locale/mk.po # locale/nb_NO.po # locale/nl.po # locale/nl_BE.po # locale/pl.po # locale/pt_BR.po # locale/pt_PT.po # locale/ro.po # locale/ru.po # locale/si_LK.po # locale/sk.po # locale/sr_Cyrl.po # locale/sr_Latn.po # locale/sv.po # locale/th_TH.po # locale/tok.po # locale/tr.po # locale/tt.po # locale/uk.po # locale/vi.po # locale/zh_CN.po # locale/zh_TW.po
Brief Description of What This PR Does
I also tried to make lysosomes evolve their enzymes but didn't get any result probably because there almost weren't any preys with chitine or cellulose membranes
Related Issues
Closes #3358
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.