Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support index param #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: support index param #2

wants to merge 6 commits into from

Conversation

giautm
Copy link

@giautm giautm commented May 4, 2021 •
edited by ArthurKnoep
Loading

Close #1

@CLAassistant
Copy link

CLAassistant commented May 4, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@giautm giautm mentioned this pull request May 4, 2021
Open
ArthurKnoep
ArthurKnoep requested changes May 5, 2021
View reviewed changes
Copy link
Member

@ArthurKnoep ArthurKnoep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🎊

Just few things to check and we should be good to go

src/main.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
giautm
giautm commented May 5, 2021
View reviewed changes
src/main.ts Outdated Show resolved Hide resolved
@giautm
Copy link
Author

giautm commented May 5, 2021

Please use Squash and merge to release as a single commit.

@ArthurKnoep
Copy link
Member

Please use Squash and merge to release as a single commit.

Yep, other merge options are disabled

Also can you update the README file, so that it reflect the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurKnoep ArthurKnoep ArthurKnoep requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support sub-directory pattern
3 participants
@giautm @CLAassistant @ArthurKnoep