Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improve SKIP_* directives #2473

Merged
merged 9 commits into from
Aug 26, 2024

Conversation

douniwan5788
Copy link
Contributor

@douniwan5788 douniwan5788 commented Aug 25, 2024

Make the FPGA bitstreams working with SKIP_* define.

Now, you can enable at least two of your favorite technologies (such as LF and HF 14443A) attached a standalone mode and still have spare ROM space for other functionalities on a Proxmark3 Easy with a 256KiB ROM.

Copy link

You are welcome to add an entry to the CHANGELOG.md as well

@douniwan5788 douniwan5788 changed the title Fixes and improve SKIP_* Fixes and improve SKIP_* directives Aug 25, 2024
@iceman1001
Copy link
Collaborator

Nice, let me know if you think its ready for merging

@douniwan5788
Copy link
Contributor Author

Looks good to me. Ready to merge!

@iceman1001 iceman1001 merged commit 42c873f into RfidResearchGroup:master Aug 26, 2024
12 checks passed
@iceman1001
Copy link
Collaborator

Awesome!

@doegox
Copy link
Contributor

doegox commented Aug 27, 2024

@douniwan5788 I'm afraid it broke sth at least on RDV4
From commit 413a17a there is something very strange going on with the FPGA...
my RDV4 becomes unresponsive after a hf 14a info, and lf search powers the HF antenna...
EDIT hmm it's fixed with a make clean. There is some missing dependency to force cleaning if order of images changes

@douniwan5788
Copy link
Contributor Author

@douniwan5788 I'm afraid it broke sth at least on RDV4 From commit 413a17a there is something very strange going on with the FPGA... my RDV4 becomes unresponsive after a hf 14a info, and lf search powers the HF antenna... EDIT hmm it's fixed with a make clean. There is some missing dependency to force cleaning if order of images changes

Yes, I also find the build system of pm3 to be quite fragile. It sometimes fails to detect certain source code changes, leading to the need for manual cleanup operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants