-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for HID SAM communication with Picopass cards #2731
support for HID SAM communication with Picopass cards #2731
Conversation
You are welcome to add an entry to the CHANGELOG.md as well |
e9db3df
to
e05c36d
Compare
Your OSX build is failing. |
Is OSX build the only one compiling client with clang instead of gcc? It catched a very nasty bug: I've accidentally limited max command length to the size of pointer, by using the macro in a wrong way. |
Yes, Only OSX builds with clang in our GH Actions. We only use |
If its all ready to merge, let me know. |
@iceman1001, I'd merge it in the current version with macro expanded by hand. |
This merge request swaps Picopass handling implementation to a similar to current SEOS handling procedures.