Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for HID SAM communication with Picopass cards #2731

Merged
merged 14 commits into from
Jan 27, 2025

Conversation

jkramarz
Copy link
Contributor

This merge request swaps Picopass handling implementation to a similar to current SEOS handling procedures.

Copy link

You are welcome to add an entry to the CHANGELOG.md as well

client/Makefile Outdated Show resolved Hide resolved
armsrc/sam_picopass.c Outdated Show resolved Hide resolved
@jkramarz jkramarz force-pushed the feature/sam_picopass branch from e9db3df to e05c36d Compare January 27, 2025 19:23
@iceman1001
Copy link
Collaborator

Your OSX build is failing.

@jkramarz
Copy link
Contributor Author

jkramarz commented Jan 27, 2025

Is OSX build the only one compiling client with clang instead of gcc? It catched a very nasty bug: I've accidentally limited max command length to the size of pointer, by using the macro in a wrong way.

@iceman1001
Copy link
Collaborator

Is OSX build the only one compiling client with clang instead of gcc? It catched a very nasty bug: I've accidentally limited max command length to the size of pointer, by using the macro in a wrong way.

Yes, Only OSX builds with clang in our GH Actions.

We only use CLIGetHexBLessWithReturn in total five places, maybe we should refactor away its use.

@iceman1001
Copy link
Collaborator

If its all ready to merge, let me know.

@jkramarz
Copy link
Contributor Author

@iceman1001, I'd merge it in the current version with macro expanded by hand.
Otherwise, I'd have to make a version of CLIGetHexWithReturn with offset (so another seldom-used macro) or use packed structs (but there's like one function doing it this way currently).

@iceman1001 iceman1001 merged commit 50b66a6 into RfidResearchGroup:master Jan 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants