Add the ability to silently use items #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, UseItem writes out text, no matter what. This is undesirable if you want it to happen silently, for example if you're making an Overworld engine and need to equip items while loading a save point, or if you have a cutscene where you equip something. Initially I was thinking of adding an Inventory.EquipItem function, but UseItem handles some equip code for some reason. Additionally, I've updated the Encounter Skeleton to reflect the new silent mode, hopefully nudging battle creators to use it when necessary.
|
Seconding this. It should be possible to change the player's equipment without automatically triggering dialog. Anyone who wants to do that has to use a workaround for awkward engine design that doesn't serve any purpose. Accessibility is extremely important for mod makers and having a forced (!) battle dialog call is needless complication. |
|
Fair enough, I don't see anything out of place with this change! |
RhenaudTheLukark
merged commit 5bbb500
into
RhenaudTheLukark:feature
1 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, UseItem writes out text, no matter what. This is undesirable if you want it to happen silently, for example if you're making an Overworld engine and need to equip items while loading a save point, or if you have a cutscene where you equip something.
Initially I was thinking of adding an Inventory.EquipItem function, but UseItem handles some equip code for some reason.
Additionally, I've updated the Encounter Skeleton to reflect the new silent mode, hopefully nudging battle creators to use it when necessary.
The documentation has been updated to reflect these changes.