Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect get_exif_date_time_offset for non-compliant exiftool -OffsetTimeOriginal values, #1697

Merged

Conversation

oPromessa
Copy link
Contributor

For non-compliant exiftool -OffsetTimeOriginal values, protect get_exif_date_time_offset prior to callingexif_offset_to_seconds. Check if offset matches '+/-hh:mm' format.

Bumped into a JPG from a friend's camera with a value of " : " on OffsetTimeOriginal!!!

$ exiftool -a -s -G1 'IMG_20YYMMDD_144722.JPG' | egrep -i "off|model"
[MacOS]         MDItemAcquisitionModel          : E-M10 Mark III
[MacOS]         MDItemFlashOnOff                : 0
[MacOS]         MDItemLensModel                 : Olympus M.Zuiko Digital 45mm F1.8
[MacOS]         MDItemRedEyeOnOff               : 0
[IFD0]          Model                           : E-M10 Mark III
[ExifIFD]       OffsetTime                      :    :
[ExifIFD]       OffsetTimeOriginal              :    :
[ExifIFD]       OffsetTimeDigitized             :    :
[ExifIFD]       LensModel                       : OLYMPUS M.45mm F1.8

…if_date_time_offset prior to callingexif_offset_to_seconds. Check if offset matches '+/-hh:mm' format.
@RhetTbull
Copy link
Owner

Thanks! I have some other work I'm trying to get merged then will tackle your PRs.

@RhetTbull RhetTbull merged commit c341a18 into RhetTbull:main Nov 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants