Proposed fix for #1703 timewarp pull-exif timezone fails to update Photos Timezone info when offset_seconds #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate, check, repair, vacuum, save-config, delete-uuid, delete-file, upgrade, sql Used "[Dryrun]" prefix in some output messages when using --dry-run. Don't know if it is aligned with the message output philosophy. ;) migrate_photos_library added to sub_commands (to run only one of sub_commands)
…vies. Aligned with push-exif location (when writing)
…ltitude in this case.
…onDate as YYYY (eg. 2014) which is converted to int, causing re.match(pattern, dt) to fail.
…te: Would it be best not to generate osxphotos_crash.log file for such situation (a bit over my level to make that change ;) ) Refactor compare_exif_no_markup and compare_exif_with_markup into timewarp_compare_exif
…r EXIF:DateTimeOriginal for videos.
…if_date_time_offset prior to callingexif_offset_to_seconds. Check if offset matches '+/-hh:mm' format.
…update Photos Timezone info when offset_seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed check for valid offset_seconds and offset variables to compare with None.