Subsetter Updates #241
Closed
Subsetter Updates #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to make sure this would be backwards-compatible, but keep your eyes peeled for anything you think might cause something to break. |
jwildfire
reviewed
Mar 8, 2019
| @@ -10,7 +10,7 @@ export default function consolidateData(raw) { | |||
| if (this.filters.length) { | |||
| this.filters.forEach(filter => { | |||
| this.filtered_data = this.filtered_data.filter(d => { | |||
| return filter.val === 'All' | |||
| return filter.all === true && filter.index === 0 | |||
There was a problem hiding this comment.
@pburnsdata Does filter.index change when the user updates a subsetter input? What code controls that update?
There was a problem hiding this comment.
yes, just like val changes - the code that controls it is below
pburnsdata
commented
Mar 8, 2019
| @@ -85,11 +96,14 @@ export default function makeSubsetterControl(control, control_wrap) { | |||
| }); | |||
| } else { | |||
| let value = select(this).select('option:checked').property('text'); | |||
| let index = select(this).select('option:checked').property('index'); | |||
There was a problem hiding this comment.
@jwildfire this is where it gets updated
samussiah
suggested changes
Mar 8, 2019
Remove css font import for open sans
jwildfire
approved these changes
Mar 13, 2019
samussiah
approved these changes
Mar 14, 2019
samussiah
suggested changes
Mar 14, 2019
build/webcharts.js
Outdated
| @@ -3068,6 +3074,8 @@ | |||
| .attr('multiple', control.multiple ? true : null) | |||
| .datum(control); | |||
|
|
|||
| var specifiedValues = controls.values; | |||
There was a problem hiding this comment.
should be control.values
samussiah
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#235
#236
#237