Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safety Delta-Delta v1.0.0 #14

Merged
merged 15 commits into from
Nov 27, 2019
Merged

Safety Delta-Delta v1.0.0 #14

merged 15 commits into from
Nov 27, 2019

Conversation

jwildfire
Copy link
Contributor

@jwildfire jwildfire commented Oct 23, 2019

Release candidate for safety-delta-delta chart.

Wiki is fully populated with standard documentation, including draft regression tests.

Repo added to CAT - you can access this branch here.

@jwildfire jwildfire requested a review from samussiah October 23, 2019 16:07
@jwildfire jwildfire self-assigned this Oct 23, 2019
@samussiah samussiah added this to the v1.0.0 milestone Oct 30, 2019
@samussiah samussiah changed the title v1.0.0 dev Safety Delta-Delta v1.0.0 Oct 30, 2019
@dschwentker
Copy link

dschwentker commented Nov 21, 2019

Regression Tests

Controls

  • Confirm that if the X or Y Measure filter is changed, the distribution of observations change.
  • Confirm that if the Baseline or Comparison Visit filters are changed, the distribution of observations change.
  • Confirm that plotted values represent the change between baseline and comparison visits for the selected measures. (Clicking points and then mousing over values in the detail table should make this relatively easy to QC).
  • Confirm that multi-select (shift-click) in Visit Filters works as expected. Participant with multiple values should have their values averaged. Click a point and mouseover points in the the detail section to confirm.
  • View x of x participants note at the bottom of the controls: check that it updates when filters are applied
  • Confirm that filters work as expected. {"filters":[{"value_col":"SITE","label":"Site"}]}
  • Confirm that if a filter is added for a variable that is not in the data, then a browser console warning is thrown. Add a made up filter such as {"filters":[{"value_col":"SOTE","label":"Sote"}]} and render the chart. Open the browser's developer tools to the Console view and look for the "The [ Sote ] filter has been removed because the variable does not exist." message.
  • Confirm that missing or non-numeric values in the dataset are handled and removed, and that the number of missing and non-numeric records appears opposite the number of participants annotation, beneath the controls. View the same Console in the developer tools and look for the "xxxx missing or non-numeric results have been removed." warning message. Download the dataset, remove some numeric values, save the datset, and then upload the new version, and render the chart. The number of missing or non-numeric values shown in the warning message should increment accordingly.
  • Confirm that if you set initial X or Y Measure to an existent value (like IgE) and render, then the chart defaults to the specified measure, but with units attached. [[[TODO: ADD CODE]]]
  • Confirm that specifying a non-existent value for a required field (such as Measure/Medical Sign or Result) and rendering the charts results in a "variable does not exist error" printed to both the console and the container element, and the chart is then destroyed. [[[TODO: ADD CODE]]]

Chart

  • Confirm that you can view a detailed listing of all measures for a participant by clicking on a point in the chart.
  • Confirm that the clicked point is highlighted with a thick black border
  • Confirm that click a different point when the detail table is shown, redraws the table for the newly clicked participant.
  • Confirm that changing any control removes the detail table.
  • Confirm that the points are not cut off on the edge of the chart.

Data Listing

  • Confirm that Participant ID is displayed above the table
  • Confirm that updating the Details option displays additional metadata above the chart [[[TODO: ADD CODE]]]
  • Confirm that the table header has "Measure" and "Change over Time" headers
  • Confirm that one row is shown for each measure collected for the clicked participant
  • Confirm that each row has the measure's name, a sparkline showing the pattern of the data over time, and a change over time value.
  • Confirm that change over time values are red if they are less than 0, green if they are greater than 0 and black if they equal 0.
  • Confirm that values where baseline or comparison visits are missing renderer with a gray "NA"
  • Confirm that in the sparkline, baseline visits are shown as filled blue circles, comparison visits are shown as filled orange circles and other visits are shown as empty gray circles.
  • Confirm that the footnote beneath the table describes the colors used in the table accurately.
  • Confirm that the currently selected x- and y-axis measures have the appropriate light blue tags.

@dschwentker
Copy link

Testing is complete. There were a few minor items I noticed and those are tracked here:
#22
#23
#24
#25

None of them necessarily need to hold up v1.0.

@samussiah samussiah requested review from dschwentker and samussiah and removed request for samussiah November 26, 2019 20:45
Copy link
Contributor

@samussiah samussiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dschwentker feature tested, good to go.

@samussiah samussiah merged commit 7f5d77c into master Nov 27, 2019
@samussiah samussiah deleted the dev-v1.0.0 branch November 27, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants