Settings schema #48
Settings schema #48
Conversation
| @@ -20,10 +20,11 @@ | |||
| ], | |||
| "dependencies": { | |||
| "d3": "^3", | |||
| "webcharts": "^1.9" | |||
| "webcharts": "^1" | |||
scripts/configuration.md
Outdated
| controls initial display of unscheduled visits | ||
|
|
||
| **default:** none | ||
|
|
scripts/configuration.md
Outdated
|
|
||
| # settings.unscheduled_visit_pattern | ||
| `string` | ||
|
|
There was a problem hiding this comment.
is this a string? or a regular expression? (maybe json schema only supports strings?)
There was a problem hiding this comment.
nevermind - i see the logic below dealing with this.
|
|
||
| **default:** `"/unscheduled|early termination/i"` | ||
|
|
||
|
|
There was a problem hiding this comment.
update based on comments from #47
| ); | ||
| settings.unscheduled_visit_regex = new RegExp(pattern, flags); | ||
| } | ||
|
|
There was a problem hiding this comment.
This looks good - should also make it easier to support config.unscheduled_visit_list as suggested in #47 code review
…ve records rather than measures
…s precedence over unscheduled_visit_pattern
|
Ready for you @jwildfire |
| const defaultSettings = { | ||
| //Custom settings for this template | ||
| import merge from './util/merge'; | ||
|
|
There was a problem hiding this comment.
Not sure I totally see the point of splitting the settings here, but I guess it doesn't hurt anything ... so 🤷♂️
There was a problem hiding this comment.
I needed to pull in the webcharts settings for the configuration wiki and this was the hacky route I chose.
src/onInit/cleanData.js
Outdated
| //Warn user of non-numeric endpoints. | ||
| if (catMeasures.length) | ||
| //Warn user of removed records. | ||
| if (nRemoved > 0) | ||
| console.warn( |
There was a problem hiding this comment.
As mentioned elsewhere, we should move this to a footnote. Created #50
jwildfire
requested review from
brittsikora
and removed request for
dschwentker
Issues
Closes #45