forked from opencv/opencv
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift Package Manager [WIP] #4
Draft
chrisballinger
wants to merge
33
commits into
master
Choose a base branch
from
swift-package
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisballinger
force-pushed
the
swift-package
branch
from
November 17, 2020 21:50
7476abc
to
b95f9d8
Compare
colejd
force-pushed
the
feature/colejd/build-catalyst-xcframework
branch
from
November 17, 2020 21:54
283cdfe
to
36c6f85
Compare
chrisballinger
force-pushed
the
swift-package
branch
from
November 17, 2020 21:57
b95f9d8
to
6975a77
Compare
6 tasks
Related: opencv#18843 |
chrisballinger
force-pushed
the
swift-package
branch
from
November 19, 2020 18:39
9c38ca1
to
ae94d35
Compare
colejd
force-pushed
the
feature/colejd/build-catalyst-xcframework
branch
from
November 20, 2020 17:26
369bc7d
to
476fc39
Compare
colejd
force-pushed
the
swift-package
branch
3 times, most recently
from
November 20, 2020 23:01
5a55be0
to
b949a72
Compare
chrisballinger
force-pushed
the
swift-package
branch
3 times, most recently
from
November 23, 2020 22:19
7963e82
to
be919ae
Compare
… namespace conflict
chrisballinger
force-pushed
the
swift-package
branch
from
November 25, 2020 18:06
ecb1e72
to
de74111
Compare
chrisballinger
changed the base branch from
feature/colejd/build-catalyst-xcframework
to
master
November 25, 2020 18:07
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing notes:
python platforms/apple/build_xcframework.py platforms/apple/xcframework-build/
or place your prebuiltopencv2.xcframework
atplatforms/apple/xcframework-build/opencv2.xcframework
swift build
Currently dealing with some interface issues with the existing Swift module from the
objc
module:I think one possible solution could be to remove the Swift stuff from the objc module and only include it via the Swift Package, but it would be a breaking change for consumers of the existing module.
TODO:
modules/core/misc/objc/test
to run viaswift test
Resolves opencv#18398