Fixed GFX running on wall time instead of sim. time #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few things are still running on wall time: Reflection+refraction water (didn't test reflection only and basic), HydraX caustics and wobbliness. Other than that (and, like in my attempt the sparks behaving weirdly) it's fine. |
|
@Miner34dev Thanks for the research, I've done a lot of water changes in #3142 so I'll fix these after it's merged. UPDATE: That PR ended up closed without merging, so I'll fix what I can here. |
I noticed beacons run when game is paused and also ignore simulation speed, always running at wall time. I remembered there are multiple other issues like this (props/water waves moving when paused) and I figured a way to tackle everything at once - I changed the time input for the entire scene update code (which is already consolidated into `GfxScene::UpdateScene()`) - instead of inputting wall time, I now input the adjusted simulation time, and I input zero if the game is paused or physics are globally paused. The particles had a custom code to correctly calc. sim. time and skip the update entirely when paused. I reverted all that, expecting the adjusted time input to fix particles, but that didn't work. I already researched this at RigsOfRods#3138 and figured to use `Ogre::ParticleSystem::setSpeedFactor()` - that did the trick.
Particles fixed: exhausts, cparticles, turboprops, turbojets, terrain object particles. Known issue: Particle time to live still runs on real time - this appears to be a bug in OGRE. Overview of changes: * Created helper `GfxScene::AdjustParticleSystemTimeFactor()`, applied to all particle systems in game. * Exhausts and CParticles moved from Actor (actor.h + simdata.h) to GfxActor (gfxactor.h + gfxdata.h). * Terrain object particle systems are now stored in vector<> in order to update their pace.
ohlidalp
force-pushed
the
gfx_simspeed_pause
branch
from
b6812a6 to
c72d1f4
Compare
|
I didn't think I can pull it off until OGRE upgrade, but I fixed HydraX caustics anim to run on simulation time instead of wall time. The only thing remaining is waves on classic water (simple/reflect/refract) - that's actually a physics (buoyance) logic, not just gfx, so it's not as easy to do, so I'll leave it out from this PR. |
CuriousMike56
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing #3169 I noticed beacons run when game is paused and also ignore simulation speed, always running at wall time. I remembered there are multiple other issues like this (props/water waves moving when paused) and I figured a way to tackle everything at once - I changed the time input for the entire scene update code (which is already consolidated into
GfxScene::UpdateScene()) - instead of inputting wall time, I now input the adjusted simulation time, and I input zero if the game is paused or physics are globally paused.The particles had a custom code to correctly calc. sim. time and skip the update entirely when paused. I reverted all that, expecting the adjusted time input to fix particles, but that didn't work - they don't use that input. I already researched this at #3138 and figured to use
Ogre::ParticleSystem::setSpeedFactor()- that did the trick.UPDATE: I synced all particles to simulation time: exhausts, cparticles, turboprops, turbojets, terrain object particles.
Known issue: Particle time to live still runs on real time - this appears to be a bug in OGRE.