Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

324 custom statistics calculation #325

Merged
merged 19 commits into from
Jul 3, 2024
Merged

324 custom statistics calculation #325

merged 19 commits into from
Jul 3, 2024

Conversation

Mnigos
Copy link
Member

@Mnigos Mnigos commented Jul 2, 2024

closes #324

@Mnigos Mnigos added the enhancement New feature or request label Jul 2, 2024
@Mnigos Mnigos requested review from volt1c and Iqro-dev July 2, 2024 14:46
@Mnigos Mnigos self-assigned this Jul 2, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.56710% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.67%. Comparing base (ec9db18) to head (cd59f58).

Files Patch % Lines
.../utils/get-most-listened-items-by-duration.util.ts 92.85% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   99.69%   99.67%   -0.02%     
==========================================
  Files          60       64       +4     
  Lines        3270     3705     +435     
  Branches      426      471      +45     
==========================================
+ Hits         3260     3693     +433     
- Misses         10       12       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Mnigos added 11 commits July 3, 2024 08:27
@Mnigos
feat(modules/stats/types): create TopItem type'
0af7596
@Mnigos
refactor(common/utils/get-most-frequent-items): return item count
c9f169e
@Mnigos
refactor(common/utils/get-most-listened-track-from-duration): return …
754e920 
…also totalDuration
@Mnigos
refactor(modules/history/tracks/repository): create `findByUserAndBet…
cdbb25b 
…weenDates` method
@Mnigos
refactor(common/utils): rename getMostListenedTracksByDuration -> `…
d0154a6 
…getMostListenedItemsByDuration`
@Mnigos
feat(modules/stats): implement getTopArtists method
c272c82
@Mnigos
feat(modules/stats): implement getTopAlbums method
339d445
@Mnigos
feat(modules/stats): implement getTopGenres method
49a5709
@Mnigos
fix(modules/history/tracks/repository): searching between dates
8b4878a
@Mnigos
perf(modules/history/tracks/repository): pass relations through argum…
878b8d8 
…ents

Pass relations throught arguments to improve loading relations performance
@Mnigos
docs(modules/stats/router): create response documents for endpoints
cd59f58
@Mnigos Mnigos marked this pull request as ready for review July 3, 2024 10:46
@Mnigos Mnigos merged commit 08af061 into main Jul 3, 2024
3 checks passed
@Mnigos Mnigos deleted the 324-custom-statistics-calculation branch July 3, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iqro-dev Iqro-dev Iqro-dev approved these changes

@volt1c volt1c Awaiting requested review from volt1c

Assignees

@Mnigos Mnigos

Labels
enhancement New feature or request
Projects
rigtch.fm
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

custom statistics calculation
2 participants
@Mnigos @Iqro-dev