Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix tsconfig and pbjs issue #574

Merged
merged 24 commits into from
Apr 27, 2024
Merged

chore: fix tsconfig and pbjs issue #574

merged 24 commits into from
Apr 27, 2024

Conversation

RyanKung
Copy link
Member

@RyanKung RyanKung commented Apr 23, 2024 •
edited
Loading

  1. tsconfig looks like not work on prepare script processing, so remove it
  2. pass --module nodenext --modueResolution nodenext --target es6 as commend arg
  3. import Long as deps for ES5, and because issue --force-number does not work protobufjs/protobuf.js#1109, we cannot use number instead
  4. With nodenext resolution, the export/import in index.ts should with file extension.

@RyanKung
add type=module in package.json
ffcc201
@RyanKung
uppercase
bce5264
@RyanKung
module es6
8dedd1b
@RyanKung
pass target=es6 to command line arg
8f5700a
@RyanKung
set moduleResolution to bundler
26a7469
@RyanKung
use tsx 5
d3dd7bd
@RyanKung
try resolution with node
2a80a28
@RyanKung
try use es5 and long type
f1d867b
@RyanKung
res to bundler
80d286f
@RyanKung
rm es6 flag for pbjs
d790805
@RyanKung
set resolution to node 16
877227b
@RyanKung
set module to node next
9de80b8
@RyanKung
modify tsconfig
78f935f
@RyanKung
Relative import paths need explicit file extensions in ECMAScript imp…
97c18e3 
…orts when '--moduleResolution' is 'node16' or 'nodenext'.
@RyanKung
export with file ext
df93969
@RyanKung
try resolution with bundler
1235c2e
@RyanKung
rm long
4f8e76d
@RyanKung
long is necessary
c1539a9
@RyanKung
force number instead of long
4ef6bb1
@RyanKung
module node next
d922d03
@RyanKung
export with extension
7e23a19
@RyanKung
rm tsconfig
998daba
@RyanKung
stil use long because of protobufjs/protobuf.js#1109
b5ad157
@RyanKung
Merge branch 'master' into chore_make_js_sdk_module
9bd9aa7
@RyanKung RyanKung requested a review from Ma233 April 25, 2024 16:44
@RyanKung RyanKung merged commit ab74421 into master Apr 27, 2024
5 checks passed
RyanKung added a commit that referenced this pull request Apr 27, 2024
@RyanKung
Revert "chore: fix tsconfig and pbjs issue (#574)"
d875165 
This reverts commit ab74421.
@RyanKung RyanKung mentioned this pull request Apr 27, 2024
Merged
RyanKung added a commit that referenced this pull request Apr 27, 2024
@RyanKung
Revert "chore: fix tsconfig and pbjs issue (#574)" (#577)
db78a22 
Reverts because it failed to load RPC components from rings_node_pb.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma233 Ma233 Ma233 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanKung @Ma233