-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new frontend with new instructions #101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punmechanic
added a commit
to punmechanic/key-conjurer
that referenced
this pull request
Nov 12, 2024
5450ae6 Add new frontend with new instructions (RiotGames#101) bdf33e5 Don't parse the updated_at field 9270394 Open a browser by default when logging in 6cabb2c Ensure account iteration order is stable 51b6b06 Return a HTTP 500 if Okta has a problem 8913eaa Improve keyconjurer accounts output 85f224a YubiKey support (RiotGames#98) REVERT: be45b54 Remove unused return value REVERT: b66a276 Run go test REVERT: 6aa2105 Remove unnecessary refs that are breaking PR builds REVERT: 10156de Conform to gorevives suggestions REVERT: ba36b5b Strip symbols REVERT: 68ff0dd Add the kitchensink module REVERT: c31df25 terraform fmt REVERT: 4d853f5 Move frontend to its own module REVERT: b5b0040 Remove KMS policy REVERT: 3531287 Add a load balancer module REVERT: 4162a4f Oops REVERT: 8fe40c3 Correct CLI_TARGETS REVERT: e939fc0 Reduce copying REVERT: 8f5d0fe Remove unnecessary quote REVERT: 89d03e8 Fold client/makefile into root REVERT: dee9d34 simplify Makefile a bit REVERT: d3a8858 Tidy up Makefile REVERT: 202b371 Fold frontend makefile into root REVERT: 27883e5 Fix up Frontend Makefile REVERT: a5ba274 Remove broken target REVERT: a4cd0f6 Rename Makefile REVERT: f467a1d Merge terraform makefile into root REVERT: ef97642 Remove unused value REVERT: 18296d1 Move Lambda function into its own module REVERT: 9ec3b05 Use a temporary dir for building this target REVERT: 4e2436e Remove note on legacy API REVERT: 4d85d5c fixup! Move lambda function to lambda/ REVERT: d42f0d5 Remove unused function REVERT: d26e60c Consolidate further REVERT: 904f522 Fold cloud.go into cli/ folder REVERT: d45aa3d Move lambda function to lambda/ REVERT: 4188119 Remove unused code REVERT: 31655c2 Go mod tidy REVERT: 764843e Consolidate pkg/ dir into internal/ directory REVERT: b7f7235 Remove local copy of the coreos-oidc dependency REVERT: 25fec03 Remove old cloud.Provider struct REVERT: 371d092 Remove legacy auth providers REVERT: f5dac64 Remove logrus REVERT: 6494834 Modernize settings REVERT: 6745a6f Remove the legacy API REVERT: 849ba0a Allow users to provide flags through KEYCONJURERFLAGS REVERT: 8159c2e Update README REVERT: dd16f4b Use a single const for the build timestamp REVERT: fd0649d Remove OneLogin test REVERT: 1928a93 Only require env variables for build target REVERT: 4f0dbf5 Don't rely on the context for the config & path REVERT: c0c49ef Refactor get REVERT: 4bb065d oops REVERT: b89ad28 Don't use configinfo outside of context REVERT: 655973b Remove appname REVERT: 2e258c2 Remove notes REVERT: 2980f1c Use buffers in test REVERT: 7bd0158 Add function for resolving credentials file REVERT: fa00d5c Simplify section managemnet REVERT: b23eac8 Remove ~/.aws/config management REVERT: f60f16f Use filepath instead of fmt Sprintf REVERT: ecdb9d1 use t.Setenv for environment variables REVERT: d5d3c90 Remove pipe REVERT: 64f0529 Store the type of credentials within the creds REVERT: 584b7e3 allow user to only output the URL REVERT: ea246e6 Provide a better error message if Okta screws up REVERT: 43cfa6a add server address const REVERT: ebbf97b add the correct ID for the application REVERT: c34d56a fix bypassing cache REVERT: 5d6788a Correctly set headers REVERT: b97ed75 Write errors in ServeJSON to log REVERT: 3180045 Fix a bug where headers werent canonized REVERT: a4e17a8 Assume headers are lowercase REVERT: 2e80e39 apply the Oauth2 header ourselves REVERT: 69bd103 Ensure a status code is set REVERT: ded014f use http.Header.Get() rather than accessing the map REVERT: e135a86 squash more bugs REVERT: a717af6 add status messages REVERT: 4ff8b00 add listener rule REVERT: 13128ca add a trailing slash REVERT: 9773a92 correct typo REVERT: 997e0b1 fix broken xargs instruction REVERT: d737cbf no longer support legacy ids REVERT: 6c7646d Fix a bug where executing a command would brick existing config REVERT: 4fc7636 Add the ability to bypass account cache REVERT: 4374fdd Don't use global variables for flags REVERT: c6bccbd Remove global quiet variable REVERT: 983c5b8 Pass configuration in context REVERT: 36c368e Simplify get REVERT: bc065ff Use AWS provider directly REVERT: e4068d6 Remove OneLogin REVERT: d045ae4 Don't use global variables for new flags REVERT: 742936c Immediately exit if --no-refresh specified REVERT: 03ce54b Move RequestAttrs to http REVERT: 177f761 Move serverless function to the serverless functions file REVERT: b199a29 Don't pre-allocate a size REVERT: 78138f4 All target must be first REVERT: 8d270e4 Correctly upload all files REVERT: fe124d8 Provide secrets to the new Lambda function REVERT: ac30889 Tag new API with lambda.norpc REVERT: a0e3b9d Use provided.al2 for the new function REVERT: 7e61d24 Modernize Makefile REVERT: c7910b9 Move new endpoint to distinguish it from legacy ones REVERT: e00f286 use CSV REVERT: 7859f5a Only enumerate Tencent or Amazon apps REVERT: e80025e Correctly list applinks for user REVERT: a3ee0ff Correctly fetch the username from the token REVERT: 1322b31 Oops REVERT: dad0fc0 fix visual errors with error reporting REVERT: c47f278 Reduce nesting REVERT: fe0e1e4 Call the KeyConjurer API instead of the Okta one REVERT: a29f435 Allow user to disable refreshing of accounts REVERT: d350649 Rename config path REVERT: e205e49 Improve logging and add to testserver REVERT: 9ccb6bd Add implementation of the new function REVERT: 7b48b69 Move Lambdaify out of main REVERT: 97c7beb add lambda <-> net/http translation layer REVERT: b4d9398 Add skeleton for new required endpoint REVERT: f7d2ddc Update Port REVERT: 66cbb19 move fetching accounts into a function REVERT: b2677bf Remove legacy accommodations REVERT: 5e085c1 Correct set the timeout REVERT: 2510385 Remove QR code device flow REVERT: 216d1d7 Use context for timeouts REVERT: aaf3f64 Add new versino of Cobra REVERT: a8c8706 Add CLIENT_ID and OIDC_DOMAIN to Makefile REVERT: 9c0a16c Simplify version flags REVERT: d1ec64b Remove host flag REVERT: 7a26205 Use consts file for client ID and OIDC domain REVERT: 3a1dea7 Modify download command to use http.Client for non windows systems REVERT: b38aeef We no longer store credentials REVERT: df593b6 add a working roles command REVERT: 639879d Implement Role & Provider finding REVERT: 3251c26 Reinstate alias resolution REVERT: efacea6 add logging to all requests we issue REVERT: fd0a05e Add basic request monitoring REVERT: dec08fe add slog REVERT: cecf8b7 Add HTTP logging middleware REVERT: 245af7a Remove base package REVERT: 2183f57 Remove unused flag REVERT: c1d4a9a Remove references to the API project from the client REVERT: 1cb0884 Fix warnings REVERT: 9068fa6 Remove unsupported roles command REVERT: 7a2b62c Remove deprecated API calls REVERT: a9ad856 Move cloud handlers to internal REVERT: a549fd8 Correctly exchange the SAML assertion for tokens REVERT: 56ae358 Return the session token when acquired REVERT: ceb95e0 Add "hidden" scope which enables the token exchange endpoint REVERT: b7be128 add some notes REVERT: 01dd811 fixup! WIP add access token exchange REVERT: 2e71142 WIP add access token exchange REVERT: 905f278 Move oauth2 stuff to.. oauth2 REVERT: 936c3b0 Remove old method of interacting with Okta here REVERT: 5ab579a Catch token expiry REVERT: 072801b Remove bad check REVERT: 884f6b1 Go mod tidy REVERT: afe05bf Display a QR code to the user REVERT: bf84d14 add qr terminal REVERT: 7372508 Correctly render accounts REVERT: 2c2ec53 Add helper method to identify that tokens have expired REVERT: 39256f2 Correctly load and store the oauth tokens REVERT: 9e13414 Move OIDC stuff to its own package REVERT: 13976e7 Go mod tidy REVERT: 665bc58 Correctly implement the device flow for Okta REVERT: 3a292fc Add oauth2device REVERT: 3690d08 Remove list providers command REVERT: d399cc0 Move OAuth2 functionality to oauth2.go REVERT: f665295 Split Login functionality into its own method REVERT: eab9cb7 Correctly generate random values REVERT: 2bc0394 Implement callback handling REVERT: b53e4c1 Add the OAuth2 flow skeleton for logging in REVERT: 45466db add oidc library REVERT: 5099552 Add Oauth2 library git-subtree-dir: keyconjurer-v2 git-subtree-split: 5450ae6
punmechanic
added a commit
to punmechanic/key-conjurer
that referenced
this pull request
Nov 12, 2024
69d489f Apply formatting changes 249bab4 Add missing articles df88087 Add Linux usage fb27555 Update MacUsage.md (RiotGames#102) 5450ae6 Add new frontend with new instructions (RiotGames#101) bdf33e5 Don't parse the updated_at field 9270394 Open a browser by default when logging in 6cabb2c Ensure account iteration order is stable 51b6b06 Return a HTTP 500 if Okta has a problem 8913eaa Improve keyconjurer accounts output 85f224a YubiKey support (RiotGames#98) REVERT: be45b54 Remove unused return value REVERT: b66a276 Run go test REVERT: 6aa2105 Remove unnecessary refs that are breaking PR builds REVERT: 10156de Conform to gorevives suggestions REVERT: ba36b5b Strip symbols REVERT: 68ff0dd Add the kitchensink module REVERT: c31df25 terraform fmt REVERT: 4d853f5 Move frontend to its own module REVERT: b5b0040 Remove KMS policy REVERT: 3531287 Add a load balancer module REVERT: 4162a4f Oops REVERT: 8fe40c3 Correct CLI_TARGETS REVERT: e939fc0 Reduce copying REVERT: 8f5d0fe Remove unnecessary quote REVERT: 89d03e8 Fold client/makefile into root REVERT: dee9d34 simplify Makefile a bit REVERT: d3a8858 Tidy up Makefile REVERT: 202b371 Fold frontend makefile into root REVERT: 27883e5 Fix up Frontend Makefile REVERT: a5ba274 Remove broken target REVERT: a4cd0f6 Rename Makefile REVERT: f467a1d Merge terraform makefile into root REVERT: ef97642 Remove unused value REVERT: 18296d1 Move Lambda function into its own module REVERT: 9ec3b05 Use a temporary dir for building this target REVERT: 4e2436e Remove note on legacy API REVERT: 4d85d5c fixup! Move lambda function to lambda/ REVERT: d42f0d5 Remove unused function REVERT: d26e60c Consolidate further REVERT: 904f522 Fold cloud.go into cli/ folder REVERT: d45aa3d Move lambda function to lambda/ REVERT: 4188119 Remove unused code REVERT: 31655c2 Go mod tidy REVERT: 764843e Consolidate pkg/ dir into internal/ directory REVERT: b7f7235 Remove local copy of the coreos-oidc dependency REVERT: 25fec03 Remove old cloud.Provider struct REVERT: 371d092 Remove legacy auth providers REVERT: f5dac64 Remove logrus REVERT: 6494834 Modernize settings REVERT: 6745a6f Remove the legacy API REVERT: 849ba0a Allow users to provide flags through KEYCONJURERFLAGS REVERT: 8159c2e Update README REVERT: dd16f4b Use a single const for the build timestamp REVERT: fd0649d Remove OneLogin test REVERT: 1928a93 Only require env variables for build target REVERT: 4f0dbf5 Don't rely on the context for the config & path REVERT: c0c49ef Refactor get REVERT: 4bb065d oops REVERT: b89ad28 Don't use configinfo outside of context REVERT: 655973b Remove appname REVERT: 2e258c2 Remove notes REVERT: 2980f1c Use buffers in test REVERT: 7bd0158 Add function for resolving credentials file REVERT: fa00d5c Simplify section managemnet REVERT: b23eac8 Remove ~/.aws/config management REVERT: f60f16f Use filepath instead of fmt Sprintf REVERT: ecdb9d1 use t.Setenv for environment variables REVERT: d5d3c90 Remove pipe REVERT: 64f0529 Store the type of credentials within the creds REVERT: 584b7e3 allow user to only output the URL REVERT: ea246e6 Provide a better error message if Okta screws up REVERT: 43cfa6a add server address const REVERT: ebbf97b add the correct ID for the application REVERT: c34d56a fix bypassing cache REVERT: 5d6788a Correctly set headers REVERT: b97ed75 Write errors in ServeJSON to log REVERT: 3180045 Fix a bug where headers werent canonized REVERT: a4e17a8 Assume headers are lowercase REVERT: 2e80e39 apply the Oauth2 header ourselves REVERT: 69bd103 Ensure a status code is set REVERT: ded014f use http.Header.Get() rather than accessing the map REVERT: e135a86 squash more bugs REVERT: a717af6 add status messages REVERT: 4ff8b00 add listener rule REVERT: 13128ca add a trailing slash REVERT: 9773a92 correct typo REVERT: 997e0b1 fix broken xargs instruction REVERT: d737cbf no longer support legacy ids REVERT: 6c7646d Fix a bug where executing a command would brick existing config REVERT: 4fc7636 Add the ability to bypass account cache REVERT: 4374fdd Don't use global variables for flags REVERT: c6bccbd Remove global quiet variable REVERT: 983c5b8 Pass configuration in context REVERT: 36c368e Simplify get REVERT: bc065ff Use AWS provider directly REVERT: e4068d6 Remove OneLogin REVERT: d045ae4 Don't use global variables for new flags REVERT: 742936c Immediately exit if --no-refresh specified REVERT: 03ce54b Move RequestAttrs to http REVERT: 177f761 Move serverless function to the serverless functions file REVERT: b199a29 Don't pre-allocate a size REVERT: 78138f4 All target must be first REVERT: 8d270e4 Correctly upload all files REVERT: fe124d8 Provide secrets to the new Lambda function REVERT: ac30889 Tag new API with lambda.norpc REVERT: a0e3b9d Use provided.al2 for the new function REVERT: 7e61d24 Modernize Makefile REVERT: c7910b9 Move new endpoint to distinguish it from legacy ones REVERT: e00f286 use CSV REVERT: 7859f5a Only enumerate Tencent or Amazon apps REVERT: e80025e Correctly list applinks for user REVERT: a3ee0ff Correctly fetch the username from the token REVERT: 1322b31 Oops REVERT: dad0fc0 fix visual errors with error reporting REVERT: c47f278 Reduce nesting REVERT: fe0e1e4 Call the KeyConjurer API instead of the Okta one REVERT: a29f435 Allow user to disable refreshing of accounts REVERT: d350649 Rename config path REVERT: e205e49 Improve logging and add to testserver REVERT: 9ccb6bd Add implementation of the new function REVERT: 7b48b69 Move Lambdaify out of main REVERT: 97c7beb add lambda <-> net/http translation layer REVERT: b4d9398 Add skeleton for new required endpoint REVERT: f7d2ddc Update Port REVERT: 66cbb19 move fetching accounts into a function REVERT: b2677bf Remove legacy accommodations REVERT: 5e085c1 Correct set the timeout REVERT: 2510385 Remove QR code device flow REVERT: 216d1d7 Use context for timeouts REVERT: aaf3f64 Add new versino of Cobra REVERT: a8c8706 Add CLIENT_ID and OIDC_DOMAIN to Makefile REVERT: 9c0a16c Simplify version flags REVERT: d1ec64b Remove host flag REVERT: 7a26205 Use consts file for client ID and OIDC domain REVERT: 3a1dea7 Modify download command to use http.Client for non windows systems REVERT: b38aeef We no longer store credentials REVERT: df593b6 add a working roles command REVERT: 639879d Implement Role & Provider finding REVERT: 3251c26 Reinstate alias resolution REVERT: efacea6 add logging to all requests we issue REVERT: fd0a05e Add basic request monitoring REVERT: dec08fe add slog REVERT: cecf8b7 Add HTTP logging middleware REVERT: 245af7a Remove base package REVERT: 2183f57 Remove unused flag REVERT: c1d4a9a Remove references to the API project from the client REVERT: 1cb0884 Fix warnings REVERT: 9068fa6 Remove unsupported roles command REVERT: 7a2b62c Remove deprecated API calls REVERT: a9ad856 Move cloud handlers to internal REVERT: a549fd8 Correctly exchange the SAML assertion for tokens REVERT: 56ae358 Return the session token when acquired REVERT: ceb95e0 Add "hidden" scope which enables the token exchange endpoint REVERT: b7be128 add some notes REVERT: 01dd811 fixup! WIP add access token exchange REVERT: 2e71142 WIP add access token exchange REVERT: 905f278 Move oauth2 stuff to.. oauth2 REVERT: 936c3b0 Remove old method of interacting with Okta here REVERT: 5ab579a Catch token expiry REVERT: 072801b Remove bad check REVERT: 884f6b1 Go mod tidy REVERT: afe05bf Display a QR code to the user REVERT: bf84d14 add qr terminal REVERT: 7372508 Correctly render accounts REVERT: 2c2ec53 Add helper method to identify that tokens have expired REVERT: 39256f2 Correctly load and store the oauth tokens REVERT: 9e13414 Move OIDC stuff to its own package REVERT: 13976e7 Go mod tidy REVERT: 665bc58 Correctly implement the device flow for Okta REVERT: 3a292fc Add oauth2device REVERT: 3690d08 Remove list providers command REVERT: d399cc0 Move OAuth2 functionality to oauth2.go REVERT: f665295 Split Login functionality into its own method REVERT: eab9cb7 Correctly generate random values REVERT: 2bc0394 Implement callback handling REVERT: b53e4c1 Add the OAuth2 flow skeleton for logging in REVERT: 45466db add oidc library REVERT: 5099552 Add Oauth2 library git-subtree-dir: keyconjurer-v2 git-subtree-split: 69d489f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new frontend with Mac instructions. I am merging this because I said so, but also to get it on dev in preparation for our new release.