Improve error handling when TTL is invalid #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punmechanic
added a commit
to punmechanic/key-conjurer
that referenced
this pull request
Nov 12, 2024
14540c4 Improve error handling when TTL is invalid (RiotGames#106) git-subtree-dir: keyconjurer-v2 git-subtree-split: 14540c4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common error scenario when requesting keys using
keyconjurer getwas that the ttl would exceed the maximum allowed for the account + role. This error would be displayed as "failed to exchange credentials" with no additional info.This PR fixes this issue by: