flux-sdk for broker apps #112
Merged
+71
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmaniar-rippling
requested changes
Jan 21, 2025
| from typing import Optional | ||
|
|
||
|
|
||
| class MemberData: |
There was a problem hiding this comment.
This looks like a loaded data object.
Can we please rethink on defining it in more better way?
Ex: Company Details are encapsulated into one class. employee details in one class. primary member, dependents, earning details, plan details, member health details inside member details and so on...
There was a problem hiding this comment.
Recheck the kit name.
Should it be broker-app? As it's not an app but a kit. And kit should be reusable across apps.
There was a problem hiding this comment.
@vmaniar-rippling ack for changing the kit name.
For MemberData , we receive census data in this flattened format itself.
vmaniar-rippling
approved these changes
Jan 22, 2025
ujjwalshukla
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flux-sdk setup for broker apps capabilities - which includes uploading census file