Remove unix.rs #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adarshr10
suggested changes
Jul 24, 2024
But should we? I seem to remember that both MacOS and Unix impls would run through libc APIs. |
|
@brhoades I am open to supporting unix. When this was internal we had agreed to only support macOS and Windows. I will have to check the unix syscall to make sure it doesn't introduce any new edge cases. My intuition is that the edge cases observed on macOS will be a superset of the edge cases on unix, so this could be a quick win. |
|
If we do end up supporting unix, I think I will also introduce a changelog to suspend-time, with v0.1.2 having one of its changes be "add unix support". I think this will be good for tracking when things were introduced in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing unix.rs. I think it got leaked in based on the way I moved this out of the internal Rippling codebase.
We do not support unix, only macOS and Windows.