Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typescript example #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add typescript example #129

wants to merge 1 commit into from

Conversation

peteyycz
Copy link
Member

No description provided.

@peteyycz peteyycz force-pushed the typescript-example branch from cd907a7 to e9f47e9 Compare March 13, 2020 10:51
@coveralls
Copy link

coveralls commented Mar 13, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 96.029% when pulling e18b8c9 on typescript-example into d0a0297 on master.

@solkimicreb solkimicreb self-requested a review March 13, 2020 11:16
solkimicreb
solkimicreb requested changes Mar 13, 2020
View reviewed changes
Copy link
Member

@solkimicreb solkimicreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the example to the relevant readme section: https://github.com/RisingStack/react-easy-state#beginner (like the other ones).

I also left a few comments. Looks nice otherwise, I look forward to merging this (:

examples/using-typescript/src/App.test.tsx Outdated Show resolved Hide resolved
examples/using-typescript/README.md Outdated Show resolved Hide resolved
types/index.d.ts Show resolved Hide resolved
@peteyycz peteyycz requested a review from rolandszoke March 13, 2020 13:29
@peteyycz peteyycz force-pushed the typescript-example branch 4 times, most recently from 3fdda90 to 5014b93 Compare March 13, 2020 16:49
solkimicreb
solkimicreb requested changes Mar 17, 2020
View reviewed changes
Copy link
Member

@solkimicreb solkimicreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed adding a new TS test command (like the current web/native/no-hook tests) that tests the ts example and ts edge cases (like forwardRef). Did you have time to do that?

examples/using-typescript/README.md Outdated Show resolved Hide resolved
types/index.d.ts Show resolved Hide resolved
examples/using-typescript/src/App.tsx Outdated Show resolved Hide resolved
@peteyycz peteyycz force-pushed the typescript-example branch 3 times, most recently from 9eaafc0 to aa5112c Compare March 17, 2020 15:02
@rolandszoke rolandszoke mentioned this pull request Mar 17, 2020
Open
rolandszoke
rolandszoke requested changes Mar 17, 2020
View reviewed changes
__tests__/UsingTypeScript.test.tsx Outdated Show resolved Hide resolved
@peteyycz peteyycz force-pushed the typescript-example branch from aa5112c to cb91fc0 Compare March 17, 2020 15:27
solkimicreb
solkimicreb requested changes Mar 17, 2020
View reviewed changes
examples/using-typescript/.gitignore Outdated Show resolved Hide resolved
examples/using-typescript/src/index.tsx Outdated Show resolved Hide resolved
jest.ts.js Outdated Show resolved Hide resolved
jest.ts.js Outdated Show resolved Hide resolved
__tests__/UsingTypeScript.test.tsx Show resolved Hide resolved
@peteyycz peteyycz force-pushed the typescript-example branch 2 times, most recently from 2416bd4 to e18b8c9 Compare March 18, 2020 16:39
solkimicreb
solkimicreb requested changes Mar 18, 2020
View reviewed changes
Copy link
Member

@solkimicreb solkimicreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 1 last comment (: and please add test-ts to the end of test command.

examples/using-typescript/.gitignore Outdated
# misc
.DS_Store
.env.local
.env.development.local
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this, please remove .env.development.local from gitignore.

@peteyycz peteyycz force-pushed the typescript-example branch from e18b8c9 to ad4511f Compare March 19, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolandszoke rolandszoke rolandszoke requested changes

@solkimicreb solkimicreb solkimicreb requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Do not merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peteyycz @coveralls @solkimicreb @rolandszoke