[OP-2240] bugfix: Fix reused memory on long files #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applejag
changed the title
jadolg
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OP-2240
Jelease failed on longer files.
Bug was that the code was using the value from
Scanner.Bytes, which gives you a slice to some underlying array that may change between scanning iterations.This bug was not visible on shorter files because the scanner/OS loads the file in chunks. Smaller files just happen to fit into the initial chunk.
The code could be optimized to not do this scanning first and iteration later, but to keep the PR small I just introduced a simple
slices.Clone.