Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created RemoteAddr plugin #1

Merged
merged 20 commits into from
Jun 10, 2024
Merged

Conversation

applejag
Copy link
Member

@applejag applejag commented Jun 6, 2024

OP-2585

This plugin is to attempt to fill the gap of where Traefik doesn't send us the X-Forwarded-Port header value that we want.

I initially tried creating this as a new fancy Traefik v3 WASM plugin, but the request interface you get there is way more limited than the one you get in the Yaegi plugins. In the WASM request interface, you didn't get access to the RemoteAddr field.

Plan is to mark this repo as public after this PR.

@applejag applejag added the enhancement New feature or request label Jun 6, 2024
@applejag applejag self-assigned this Jun 6, 2024
@applejag applejag requested a review from jadolg June 6, 2024 19:20
@applejag applejag marked this pull request as ready for review June 6, 2024 19:48
plugin.go Outdated Show resolved Hide resolved
plugin.go Outdated Show resolved Hide resolved
plugin_test.go Show resolved Hide resolved
plugin_test.go Outdated Show resolved Hide resolved
@applejag applejag requested a review from jadolg June 10, 2024 11:52
Copy link
Member

@jadolg jadolg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@applejag applejag merged commit 70b1893 into main Jun 10, 2024
7 checks passed
@applejag applejag deleted the feature/OP-2585/remoteaddr-plugin branch June 10, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants