Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child class reliant on "LIKE" temp-table defined in parent does not compile incrementally after schema change #537

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kenherring-rkt
Copy link
Contributor

Description

When compiling incrementally after a schema change child classes which are reliant on a temp-table defined in a parent class using the LIKE phrase do not re-compile. When subsequently running the code we see the following error:

   [PCTRun] TEMP-TABLE 'ttCustomer' of class 'cls.someChildClass' no longer matches the definition in base class 'cls.someClass'. (13203)
   [PCTRun] Could not access element 'ttCustomer' of class 'cls.someClass' using object of type 'cls.someChildClass' - caller compilation is out of sync with class compilation. (12882)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My branch is started from the latest commit in main
  • My commit history is clean
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@kenherring-rkt kenherring-rkt marked this pull request as draft July 23, 2024 21:36
@kenherring-rkt
Copy link
Contributor Author

I don't have a fix for this yet, but wanted to create the PR so there's awareness that I intend to do so.

@gquerret
Copy link
Contributor

Check importXref procedure: https://github.com/Riverside-Software/pct/blob/main/src/progress/pct/compile.p#L786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants