nuke-build#1495 Not properly handling one argument with spaces

Roadrunner67 · Jan 1, 2025 · b567c75 · b567c75
1 parent 5b4f3ca
commit b567c75
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/source/Nuke.Tooling.Tests/ArgumentStringHandlerTest.cs b/source/Nuke.Tooling.Tests/ArgumentStringHandlerTest.cs
@@ -1,4 +1,4 @@
-// Copyright 2023 Maintainers of NUKE.
+// Copyright 2023 Maintainers of NUKE.
 // Distributed under the MIT License.
 // https://github.com/nuke-build/nuke/blob/master/LICENSE
 
@@ -61,6 +61,12 @@ public void TestAbsolutePathCollection()
         ArgsToString($"start {paths:sn} end").Should().Be("start C:\\foo\\bar '/foo bar/foo' end");
     }
 
+    [Fact]
+    public void TestSpacedPathOnly()
+    {
+        ArgsToString($"{(AbsolutePath)"C:" / "Program Files"}").Should().Be("\"C:\\Program Files\"");
+    }
+
     [Fact]
     public void TestFormat()
     {

diff --git a/source/Nuke.Tooling/ArgumentStringHandler.cs b/source/Nuke.Tooling/ArgumentStringHandler.cs
@@ -81,7 +81,7 @@ public void AppendFormatted(IEnumerable<IAbsolutePathHolder> paths, int alignmen
     public string ToStringAndClear()
     {
         var value = _builder.ToStringAndClear();
-        return value.Length > 1 &&  value.IndexOf(value: '"', startIndex: 1) == value.Length - 1
+        return value.Length > 1 &&  value.IndexOf(value: '"', startIndex: 1) == value.Length - 1 && value.IndexOf(' ') == -1
             ? value.TrimMatchingDoubleQuotes()
             : value;
     }