Fixing issue 501

RoaringBitmap · Sep 6, 2023 · 78b3e4d · 78b3e4d
1 parent 33da04d
commit 78b3e4d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.github/workflows/macos-ci.yml b/.github/workflows/macos-ci.yml
@@ -22,6 +22,15 @@ jobs:
           ctest . --output-on-failure
           cmake --install . 
           cd ../tests/installation/find && mkdir build && cd build && cmake -DCMAKE_INSTALL_PREFIX:PATH=../../../build/destination .. &&  cmake --build .
+      - name: Build and Test (shared)
+        run: |
+          cmake -DBUILD_SHARED_LIBS=ON -B buildshared -DCMAKE_INSTALL_PREFIX:PATH=destinationshared
+          cmake --build buildshared
+          cmake --install buildshared
+          cd tests/installation/find
+          cmake -DCMAKE_INSTALL_PREFIX:PATH=../../../destinationshared -B buildshared
+          cmake --build buildshared
+          ./buildshared/repro
       - name: Build and Test Debug
         run: |
           mkdir builddebug

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -5,7 +5,6 @@ project(RoaringBitmap
 )
 include(GNUInstallDirs)
 
-set(CMAKE_MACOSX_RPATH OFF)
 if (NOT CMAKE_BUILD_TYPE)
                 message(STATUS "No build type selected, default to Release")
                 set(CMAKE_BUILD_TYPE Release CACHE STRING "Choose the type of build." FORCE)