fix use nil parameter, the MinMaxBig func will throw panic's problem

[ChicChip]

i fixed fix use nil parameter, the MinMaxBig func will throw panic's problem (#455)

[guymolinari]

Could you also look at CompareBigValue ad well? El mié, 30 de oct de 2024, 8:15 p. m., ChicChip ***@***.***> escribió:

…

i fixed fix use nil parameter, the MinMaxBig func will throw panic's problem (#455 <#455>) ------------------------------ You can view, comment on, or merge this pull request online at: #456 Commit Summary - 32dbf71 <32dbf71> fix use nil parameter, the MinMaxBig func will throw panic's problem File Changes (2 files <https://github.com/RoaringBitmap/roaring/pull/456/files>) - *M* roaring64/bsi64.go <https://github.com/RoaringBitmap/roaring/pull/456/files#diff-d1a31b49d0996408823b8c849e138363be8a4347d2e57cafd0ad289768845b46> (4) - *M* roaring64/bsi64_test.go <https://github.com/RoaringBitmap/roaring/pull/456/files#diff-7fb44386e5551c3e6747d640bd9e1d99e75284a02b94ca0177849c566b86fc2f> (6) Patch Links: - https://github.com/RoaringBitmap/roaring/pull/456.patch - https://github.com/RoaringBitmap/roaring/pull/456.diff — Reply to this email directly, view it on GitHub <#456>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADZZAUQP5YU4OGSSPCDL4X3Z6GHENAVCNFSM6AAAAABQ5L3RG2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGYZDKOBRGI3TGNY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[ChicChip]

in bsi64.go and bsi.go file, if foundSet is nil, is it all set to exisitence bitmap?

[ChicChip]

i think these function may all hava nil pointer problem when parameter is nil

1. TransposeWithCounts
2. SumBigValues
3. IntersectAndTranspose
4. TransposeWithCounts
5. Increment

[guymolinari]

Yes. Also in CompareBigValue. If 'end' is not set it will panic also El jue, 31 de oct de 2024, 3:37 a. m., ChicChip ***@***.***> escribió:

…

in bsi64.go and bsi.go file, if foundSet is nil, is it all set to exisitence bitmap? — Reply to this email directly, view it on GitHub <#456 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADZZAUU72LVNI6DXY7W34L3Z6H24LAVCNFSM6AAAAABQ5L3RG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBZGQZDKMBSGE> . You are receiving this because you commented.Message ID: ***@***.***>

[ChicChip]

i think these function may all hava nil pointer problem when parameter is nil

1. TransposeWithCounts
2. SumBigValues
3. IntersectAndTranspose
   --4. TransposeWithCounts
4. Increment

I have set default value for these function, include CompareBigValue

[lemire]

Running tests.