Initial structure of docbook tool process #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
changed the title
asgrim
force-pushed
the
basic-feature-work
branch
from
af71f32 to
c5284b2
Compare
asgrim
commented
Jan 28, 2021
asgrim
commented
Jan 28, 2021
asgrim
changed the title
…in PlantUML png generation
Ocramius
requested changes
Jan 28, 2021
Ocramius
approved these changes
Jan 28, 2021
|
|
||
| (new WriteAllTheOutputs($outputWriters))( | ||
| array_map( | ||
| [new AggregatePageFormatter($pageFormatters), '__invoke'], |
There was a problem hiding this comment.
Weird - did it not work with just new AggregatePageFormatter() (considering it's already callable)?
There was a problem hiding this comment.
No idea, I didn't actually check 😅
There was a problem hiding this comment.
Interesting:
ERROR: MixedArgumentTypeCoercion - bin/docbook-tool.php:46:9 - Argument 1 of Roave\DocbookTool\WriteAllTheOutputs::__invoke expects array<array-key, Roave\DocbookTool\DocbookPage>, parent type array<array-key, mixed> provided (see https://psalm.dev/194)
array_map(
new AggregatePageFormatter($pageFormatters),
(new RecursivelyLoadPagesFromPath())($contentPath)
)
------------------------------
1 errors found
------------------------------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.