DRAFT: Adoptopenjdk #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't we link them somehow/add an include path to a clone of the openjdk instead of copying the files? |
Sure, this was just a draft |
|
Also what code that we already have in place would this replace? The classfile parser? |
This would make it possible to use openjdk. We don't have any code for that |
|
See #7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains code from opendjk, I'm not sure if we are allowed to do that.
To try this download https://adoptopenjdk.net/?variant=openjdk16&jvmVariant=hotspot and copy our
libjvm.sofrom the bulild folder into/lib/server. Then/bin/javawill use our version instead.I think implementing all of this is way too much work though.
One problem would be to load classes from the
modules. I don't know if we can simply treatjmodsas jar files or if we would have to readlib/modules. Java 8 would definitely be simpler in this regard because everything is inrt.jarand we wouldn't have to deal with modules. See also: java/lang/System::initPhase2I've noticed that many functions were removed from jvm.h in version 11 compared to version 8. The new functions are mostly about modules and StackWalker. Version 16 became a bit more complicated and they split up some files.