Add BigInt64Array and BigUint64Array to the new-for-builtins ru…

…le (sindresorhus#353)
RobinBetty · Sep 6, 2019 · e7ff2de · e7ff2de
1 parent 1c50548
commit e7ff2de
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/docs/rules/new-for-builtins.md b/docs/rules/new-for-builtins.md
@@ -7,6 +7,8 @@ Enforces the use of `new` for following builtins:
 - `Object`
 - `Array`
 - `ArrayBuffer`
+- `BigInt64Array`
+- `BigUint64Array`
 - `DataView`
 - `Date`
 - `Error`

diff --git a/rules/new-for-builtins.js b/rules/new-for-builtins.js
@@ -5,6 +5,8 @@ const enforceNew = new Set([
 	'Object',
 	'Array',
 	'ArrayBuffer',
+	'BigInt64Array',
+	'BigUint64Array',
 	'DataView',
 	'Date',
 	'Error',

diff --git a/test/new-for-builtins.js b/test/new-for-builtins.js
@@ -23,6 +23,8 @@ ruleTester.run('new-for-builtins', rule, {
 		'const foo = new Object()',
 		'const foo = new Array()',
 		'const foo = new ArrayBuffer()',
+		'const foo = new BigInt64Array()',
+		'const foo = new BigUint64Array()',
 		'const foo = new DataView()',
 		'const foo = new Date()',
 		'const foo = new Error()',
@@ -65,6 +67,16 @@ ruleTester.run('new-for-builtins', rule, {
 			errors: [enforceNewError('ArrayBuffer')],
 			output: 'const foo = new ArrayBuffer()'
 		},
+		{
+			code: 'const foo = BigInt64Array()',
+			errors: [enforceNewError('BigInt64Array')],
+			output: 'const foo = new BigInt64Array()'
+		},
+		{
+			code: 'const foo = BigUint64Array()',
+			errors: [enforceNewError('BigUint64Array')],
+			output: 'const foo = new BigUint64Array()'
+		},
 		{
 			code: 'const foo = DataView()',
 			errors: [enforceNewError('DataView')],