Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ref: Workspaces #2374

Merged
merged 60 commits into from
Feb 8, 2025
Merged

Ref: Workspaces #2374

merged 60 commits into from
Feb 8, 2025
+1,628 −3,585

Conversation

RobinTail
Copy link
Owner

Reiteration of #1351 having improved dependencies and environment

@RobinTail RobinTail added refactoring The better way to achieve the same result CI/CD labels Feb 7, 2025
@RobinTail RobinTail added coverage Additional tests miracle Mysterious events are happening here labels Feb 7, 2025
@RobinTail
Copy link
Owner Author

Hooley sheet!
it worked out this time

@RobinTail RobinTail changed the title Exp: workspaces Ref: orkspaces Feb 7, 2025
@RobinTail RobinTail changed the title Ref: orkspaces Ref: Workspaces Feb 7, 2025
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Feb 7, 2025 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 97d032b on again-workspaces
into d848cd4 on master.

RobinTail
RobinTail commented Feb 7, 2025
View reviewed changes
express-zod-api/logo.svg Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Feb 8, 2025
View reviewed changes
.github/workflows/beta.yml Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Feb 8, 2025
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good.
need to review manifests and lock file once again

RobinTail
RobinTail commented Feb 8, 2025
View reviewed changes
package.json Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Feb 8, 2025
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

upgrades should be conducted using the following command:

yarn workspace express-zod-api upgrade

@RobinTail
Copy link
Owner Author

✅ the diff is OK
https://npmdiff.dev/express-zod-api/22.6.0/22.7.0-beta.0/

@RobinTail
Copy link
Owner Author

✅ QA passed

@RobinTail RobinTail added the documentation Improvements or additions to documentation label Feb 8, 2025
RobinTail
RobinTail commented Feb 8, 2025
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready

@RobinTail RobinTail merged commit e6faaf8 into master Feb 8, 2025
9 checks passed
@RobinTail RobinTail deleted the again-workspaces branch February 8, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI/CD coverage Additional tests documentation Improvements or additions to documentation miracle Mysterious events are happening here refactoring The better way to achieve the same result
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail