Additional clarification on GuiBase2d.AbsolutePosition #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed change to the AbsolutePosition property's note: "Note that the object's AnchorPoint influences AbsolutePosition." The note, while true, is a bit misleading, and more clarification is needed to ensure users know AbsolutePosition always represents the top-left corner of a GuiBase2d element.
github-actions
bot
added
the
engine reference
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @Cens-r, thanks so much for helping improve the Roblox creator documentation! Our technical writing team will review your pull request soon. In the meantime, please ensure you've read through the README.md, contribution guidelines, and style recommendations.
IgnisRBX
reviewed
Jan 6, 2025
Comment on lines
26
to
27
| renders as a result of its ancestors' sizes and positions. Note that the | ||
| object's `Class.GuiObject.AnchorPoint|AnchorPoint` influences |
There was a problem hiding this comment.
Suggested change
| renders as a result of its ancestors' sizes and positions. Note that the | |
| object's `Class.GuiObject.AnchorPoint|AnchorPoint` influences | |
| renders as a result of its ancestors' sizes and positions. Note that |
IgnisRBX
reviewed
Jan 6, 2025
Comment on lines
+28
to
+29
| `Class.GuiBase2d.AbsolutePosition|AbsolutePosition`, but it will always | ||
| represent the top-left corner of the `Class.GuiBase2d` element. |
There was a problem hiding this comment.
Suggested change
| `Class.GuiBase2d.AbsolutePosition|AbsolutePosition`, but it will always | |
| represent the top-left corner of the `Class.GuiBase2d` element. | |
| `Class.GuiBase2d.AbsolutePosition|AbsolutePosition` always | |
| represents the top-left corner of the `Class.GuiBase2d` element. |
|
IMHO we can just omit mention of AnchorPoint here, since that changes the position of the element on screen and does (as previously stated) affect AbsolutePosition, but the main takeaway is that AbsolutePosition represents the top-left corner of the object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
To avoid potentially misleading vagueness, this PR makes minor changes to the note's wording within the description of the
AbsolutePositionproperty ofGuiBase2delements. Clarification that the property will always represent the top-left corner of aGuiBase2d, regardless of the ambiguous "influences"AnchorPointhas on theAbsolutePosition.Checks
By submitting your pull request for review, you agree to the following: