-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HttpService.yaml #966
Open
sammygrey
wants to merge
3
commits into
Roblox:main
Choose a base branch
from
sammygrey:patch-5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added information for HTTP methods, what they are, and if they are currently supported by Roblox's HTTPService
github-actions
bot
added
the
engine reference
Changes the Engine API Reference documentation
label
Jan 1, 2025
github-actions
bot
added
the
changes requested
This pull request has changes requested prior to merging
label
Jan 1, 2025
Added https://developer.mozilla.org/ to the list of allowed HTTP links
https://developer.mozilla.org/ is a resource for all things web-development. The links in the proposed changes for HttpService.yaml link to detailed info on each of the listed HTTP methods. |
guessing the check system doesn't whitelist all child urls under a parent url
Please lmk if parent URLs whitelist child URLs, I don't want to clutter the allowedlinks file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changes requested
This pull request has changes requested prior to merging
engine reference
Changes the Engine API Reference documentation
tools
Makes non-content changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added information for HTTP methods, what each of them are, and if they are currently supported by Roblox's HTTPService.
Connect is the only method not currently supported. This is likely because it creates an information tunnel between the target server and the server requesting the connection. I can provide the code I used to test each of the methods, but it's just a pretty simple express server and Roblox script. I'll make a feature request for the Connect method but I think its pretty unlikely that will ever get added.
I also don't know if it's a problem that I linked 3rd party sources (Mozilla Docs), but Roblox doesn't have pages for the individual HTTP methods and I don't believe it would make sense to add individual pages for them as it entirely relates to the HTTPService.
Checks
By submitting your pull request for review, you agree to the following: