Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HttpService.yaml #966

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update HttpService.yaml #966

wants to merge 3 commits into from

Conversation

sammygrey
Copy link
Contributor

Changes

Added information for HTTP methods, what each of them are, and if they are currently supported by Roblox's HTTPService.

Connect is the only method not currently supported. This is likely because it creates an information tunnel between the target server and the server requesting the connection. I can provide the code I used to test each of the methods, but it's just a pretty simple express server and Roblox script. I'll make a feature request for the Connect method but I think its pretty unlikely that will ever get added.

I also don't know if it's a problem that I linked 3rd party sources (Mozilla Docs), but Roblox doesn't have pages for the individual HTTP methods and I don't believe it would make sense to add individual pages for them as it entirely relates to the HTTPService.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

Added information for HTTP methods, what they are, and if they are currently supported by Roblox's HTTPService
@sammygrey sammygrey requested a review from a team as a code owner January 1, 2025 02:40
@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label Jan 1, 2025
@github-actions github-actions bot added the changes requested This pull request has changes requested prior to merging label Jan 1, 2025
Added https://developer.mozilla.org/ to the list of allowed HTTP links
@sammygrey sammygrey requested review from a team as code owners January 1, 2025 02:43
@sammygrey sammygrey requested a review from zovits January 1, 2025 02:43
@github-actions github-actions bot added the tools Makes non-content changes label Jan 1, 2025
@sammygrey
Copy link
Contributor Author

https://developer.mozilla.org/ is a resource for all things web-development. The links in the proposed changes for HttpService.yaml link to detailed info on each of the listed HTTP methods.

guessing the check system doesn't whitelist all child urls under a parent url
@sammygrey
Copy link
Contributor Author

Please lmk if parent URLs whitelist child URLs, I don't want to clutter the allowedlinks file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested This pull request has changes requested prior to merging engine reference Changes the Engine API Reference documentation tools Makes non-content changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant