Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed thirds, added communication-based heuristic for seeking #2226

Merged
merged 6 commits into from
Mar 16, 2024

Conversation

sanatd33
Copy link
Contributor

Description

Removed thirds, added communication-based heuristic for seeking

Associated / Resolved Issue

Resolves https://app.clickup.com/t/86azggjjb

Key Files to Review

  • offense.cpp
  • seeker.cpp

automated style fixes

Co-authored-by: sanatd33 <[email protected]>
Copy link
Contributor

@sid-parikh sid-parikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes and one question

* automated style fixes

* Update seeker.cpp

---------

Co-authored-by: sanatd33 <[email protected]>
Co-authored-by: Sanat Dhanyamraju <[email protected]>
automated style fixes

Co-authored-by: sanatd33 <[email protected]>
@sanatd33 sanatd33 requested review from rishiso and sid-parikh March 14, 2024 17:20
Copy link
Contributor

@rishiso rishiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sid-parikh sid-parikh merged commit 224b72c into ros2 Mar 16, 2024
2 checks passed
@sid-parikh sid-parikh deleted the fix-seeking branch March 16, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants