add ros env vars to source script #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksherling
approved these changes
Oct 2, 2024
shourikb
approved these changes
Oct 2, 2024
piman51277
pushed a commit
that referenced
this pull request
Oct 6, 2024
Squid5678
pushed a commit
that referenced
this pull request
Oct 28, 2024
shourikb
pushed a commit
that referenced
this pull request
Oct 30, 2024
jacksherling
added a commit
that referenced
this pull request
Nov 6, 2024
* Created a new motion planner called rotation planner. It is a work in progress. This planner should theoretically only be rotation around a point (in our case, we are developing it to rotate about itself). * tested some theory about the problem. With changing the values in points, we have pinpointed the likely problem. If the two rotation points are the current pivot point and the point (0, 0), it will rotate but also translate. If the only points in the rotation are the pivot point, it will try to plan but get stuck. This is because we try to move to the same point that we are already at, so we think it is done because planners check they are done by translation. However, we need to make this one check it is done by its orientation. * trapezoid angle planning * end 09/08 * updated files * Dribble in Sim (#2287) * dribbler is stupid * use realism * add realism to simoulator cli run --------- Co-authored-by: petergarud <[email protected]> * add ros env vars to source script (#2288) * Update tutorial.rst (#2286) * fixed rebase issues * Fix Code Style On rotate-kick (#2300) automated style fixes Co-authored-by: Squid5678 <[email protected]> * changes * Fix Code Style On rotate-kick (#2303) automated style fixes Co-authored-by: Squid5678 <[email protected]> * change to is angle done threshold * removing SPDLOG stuff * removed unnecessary line pivot changes * gitignore * remove log stuff * comments --------- Co-authored-by: Shourik Banerjee <[email protected]> Co-authored-by: rishiso <[email protected]> Co-authored-by: Sanat Dhanyamraju <[email protected]> Co-authored-by: petergarud <[email protected]> Co-authored-by: Sid Parikh <[email protected]> Co-authored-by: Jack <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Squid5678 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ROS2 enviornment was messed up --
ros2 topic listwould not result in anything in a new terminal. I identified that ros expects certain env vars to be the same in all shells that are talking about the "same" ros processesAssociated / Resolved Issue
Resolves ClickUp card
Steps to Test
Test Case 1
Expected result: you see all the topics
Key Files to Review
Questions
Review Checklist