Removed extra TELNET_SERVER_VERBOSE_LOGGING define #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example just had `VERBOSE` in the logger config, but that wasn't enough. Because the default log level of esphome is `debug`, I think having these print when a user opts into `verbose` is probably fine, without needing an extra `verbose: true` in the config. All other stock esphome components just depend on the logger config too.
|
Another option could be the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example just had
VERBOSEin the logger config, but that wasn't enough.Because the default log level of esphome is
debug, I think having these print when a user opts intoverboseis probably fine, without needing an extraverbose: truein the config.All other stock esphome components just depend on the logger config too.