Added Write support and bring your own uart #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a couple of things that are hard to untangle into different pull requests. 1. Adds bring your own uart For my use case I wanted to watch the serial port from another device, _not_ the serial port that happened to be on the esp32 that esphome was using for logging (which I would like to keep). This makes the configuration a little harder for the normal case, but it is more explicit. 2. Added write support I wanted to be able to log into my other remote device, so I added write support 3. Added multi-support I want to be able to have multiple of these, like a serial console server. Only `MULTI_CONF = True` was required to make this happen, once the `uart_id` was ready. This also removes the Arduino'ism for serial, as we are depending on ESPhome's uart code, which is kinda cool. Should work on any controller supported by ESPHome and any framework with this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a couple of things that are hard to untangle into different pull requests.
For my use case I wanted to watch the serial port from another device, not the serial port that happened to be on the esp32 that esphome was using for logging (which I would like to keep). This makes the configuration a little harder for the normal case, but it is more explicit.
I wanted to be able to log into my other remote device, so I added write support
I want to be able to have multiple of these, like a serial console server. Only
MULTI_CONF = Truewas required to make this happen, once theuart_idwas ready.This also removes the Arduino'ism for serial, as we are depending on ESPhome's uart code, which is kinda cool. Should work on any controller supported by ESPHome and any framework with this PR.
Note that I'll rebase this if/after the other PRs are merged.