-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snapshot system #59
base: master
Are you sure you want to change the base?
Conversation
Hi @JaydenGrubb1 - thanks a lot for this! When creating the snapshot, can you please change the functionality such that versions are captured for ALL packages in the rosdistro? |
Updated to snapshot all packages in the rosdistro. |
Hi @wolfv / @traversaro - do you have time to review? @JaydenGrubb1 is just finishing a project with me, and this + #64 are his main deliverables. |
Thanks! Just a non-blocking comment, how does it work if a package is present in the new distro but not in the snapshot? It silently tries to build the latest version? |
Your right. As is, it would just try to build the latest version. I guess the correct behaviour would be to skip the package instead? |
I guess so? From what I understand the goal of this feature is to easily rebuild the packages with updated dependencies and fixes, without having to deal with regression due to new versions released. In that context, trying to release new packages could create problems. |
Added a snapshot utility
vinca-snapshot
for capturing the current version of specified ROS packages. This snapshot can then be used when generating recipes via-z/--snapshot PATH
.