Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot system #59

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

JaydenGrubb1
Copy link

Added a snapshot utility vinca-snapshot for capturing the current version of specified ROS packages. This snapshot can then be used when generating recipes via -z/--snapshot PATH.

@Tobias-Fischer
Copy link
Contributor

Hi @JaydenGrubb1 - thanks a lot for this! When creating the snapshot, can you please change the functionality such that versions are captured for ALL packages in the rosdistro?

@JaydenGrubb1
Copy link
Author

Updated to snapshot all packages in the rosdistro.

@Tobias-Fischer
Copy link
Contributor

Hi @wolfv / @traversaro - do you have time to review? @JaydenGrubb1 is just finishing a project with me, and this + #64 are his main deliverables.

@traversaro
Copy link
Member

Thanks! Just a non-blocking comment, how does it work if a package is present in the new distro but not in the snapshot? It silently tries to build the latest version?

@JaydenGrubb1
Copy link
Author

Your right. As is, it would just try to build the latest version. I guess the correct behaviour would be to skip the package instead?

@traversaro
Copy link
Member

Your right. As is, it would just try to build the latest version. I guess the correct behaviour would be to skip the package instead?

I guess so? From what I understand the goal of this feature is to easily rebuild the packages with updated dependencies and fixes, without having to deal with regression due to new versions released. In that context, trying to release new packages could create problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants