Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cache sample queries #265

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Feature/cache sample queries #265

merged 4 commits into from
Jul 25, 2023

Conversation

Woozl
Copy link
Member

@Woozl Woozl commented Jul 25, 2023

A simple way of caching the responses for the 5 sample queries on the main page. Closes RobokopU24/Feedback#173, although we may want to look for a more robust solution.

Downsides:

  • will get out of sync with the KG eventually, requiring the file to be manually updated
  • will not scale well to a large number of queries

@Woozl
move sample queries to json file
572b11a
@Woozl
fix lint error
3aaff95
@Woozl
add json response to sample query file as a cache
5c4f2b6
@Woozl
move sample query + cache to the server side
042ae44 
keep just the sample queries on the client bundle so it doesn't add 18MB

intercept the /quick_answer route to see if the req.body matches a sample query
@Woozl Woozl merged commit ed3b3ea into staging Jul 25, 2023
2 checks passed
@Woozl Woozl deleted the feature/cache-sample-queries branch July 25, 2023 21:25
@Woozl Woozl mentioned this pull request Jul 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Woozl