Ensure Java consistency on macOS #299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolecheetham
commented
Nov 19, 2024
There was a problem hiding this comment.
+@BetsyMcPhail for feature review please
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @BetsyMcPhail)
|
The experimental job I have running to test this PR: https://drake-jenkins.csail.mit.edu/view/Mac%20Sonoma%20Unprovisioned/job/mac-arm-sonoma-unprovisioned-clang-bazel-experimental-everything-release/ Had errors regarding pining temurin@17 |
nicolecheetham
force-pushed
the
mac_java_installs
branch
from
1240ffc
to
859d459
Compare
nicolecheetham
force-pushed
the
mac_java_installs
branch
2 times, most recently
from
5f79b48
to
6abeeb8
Compare
nicolecheetham
force-pushed
the
mac_java_installs
branch
from
0c2413c
to
fcfefec
Compare
BetsyMcPhail
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nicolecheetham)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures the specific java version installed stays consistent throughout an entire job. This aims to prevent breakage from future Homebrew updates.
Also, removes the outdated --ignore-pinned argument
Towards: #22089
This change is