-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example showing usage of resource from an external ROS package in Drake #1
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
|
||
target_link_libraries(${PROJECT_NAME} drake::drake) | ||
|
||
install(FILES LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this install()
fails for me because there's no LICENSE file in drake_example_pendulum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed this since there's only one LICENSE file at the top directory of this repo. 5747a7c
<url type="bugtracker">https://github.com/RobotLocomotion/drake-ros/issues</url> | ||
<url type="repository">https://github.com/RobotLocomotion/drake-ros</url> | ||
<buildtool_depend>ament_cmake</buildtool_depend> | ||
<exec_depend>drake_example_pendulum_description</exec_depend> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind adding <depend>drake</depend>
? With that I'm able to build this together with RobotLocomotion/drake
in an isolated colcon workspace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. 5747a7c
Signed-off-by: Addisu Z. Taddese <[email protected]>
|
||
// Populate from AMENT_PREFIX_PATH environment variable to find URDF files and | ||
// their resources, such as meshes. | ||
parser.package_map().PopulateFromEnvironment("AMENT_PREFIX_PATH"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IanTheEngineer @EricCousineau-TRI any interest in in this example?
A lot has changed since this PR opened. I think now we'd put this in a folder in drake_ros_examples
. The key piece of information appears to be calling PackageMap::PopuldateFromEnvironment
with AMENT_PREFIX_PATH
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a very reasonable approach. Let's make this a simple example populating the Drake package_map
from the local ROS environment inside drake_ros_examples
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's revive this once #207 lands!
nit See also drake::parsing::PackageMap::PopulateFromRosPackagePath(). That function obeys AMENT_IGNORE, whereas Possibly we should extend/amend that Drake function for this purpose, instead of using |
Reopening RobotLocomotion/drake-external-examples#194 here.
This adds an example of loading a URDF from an external ROS package. The URDF contains a mesh with a
package://
type URI. For this to be found, I populate the package map fromAMENT_PREFIX_PATH
as described in #170.In addition to the pendulum related packages, I copied the
scripts
directory from https://github.com/RobotLocomotion/drake-external-examples for the convenient installation scripts that were referenced in the README.Closes RobotLocomotion/drake-external-examples#170
cc @IanTheEngineer , @EricCousineau-TRI
This change is