Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazelisk] Use Bazel 7.1.2 #349

Merged

Conversation

EricCousineau-TRI
Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI commented May 13, 2024

To match Anzu


This change is Reviewable

Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@jwnimmer-tri Could I request your review here?

\cc @calderpg-tri @IanTheEngineer

Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on @jwnimmer-tri)

@jwnimmer-tri
Copy link
Contributor

Seems like the kind of thing that's fine for a self-rubber-stamp.

Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, thanks! +@EricCousineau-TRI :lgtm:

Reviewable status: 0 of 10 files reviewed, all discussions resolved (waiting on @EricCousineau-TRI and @jwnimmer-tri)

install_prereqs: Use Bazelisk
environ.bzl: Use workaround for attr.string_list() from Anzu

Co-Authored-By: Jeremy Nimmer <[email protected]>
Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jwnimmer-tri)

@EricCousineau-TRI EricCousineau-TRI merged commit f3c5497 into RobotLocomotion:main May 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants